Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New action to reload an individual view and all of its children #7362

Merged
merged 19 commits into from
Jan 25, 2024
Merged

New action to reload an individual view and all of its children #7362

merged 19 commits into from
Jan 25, 2024

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Jan 9, 2024 •
edited by ozyx
Loading

Closes #7343

Describe your changes:

Adds new action for objects to reload themselves and their children.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@scottbell scottbell linked an issue Jan 9, 2024 that may be closed by this pull request
New action to reload an individual view and all of its children #7343
Closed
@scottbell scottbell added type:feature Feature. Required intentional design type:enhancement and removed type:feature Feature. Required intentional design labels Jan 9, 2024
@deploysentinel DeploySentinel
Copy link

deploysentinel bot commented Jan 9, 2024 •
edited
Loading

Current Playwright Test Results Summary

✅ 15 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/11/2024 11:48:06am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: e64bafe

Started: 01/11/2024 11:46:23am UTC

View Detailed Build Results

Current Playwright Test Results Summary

✅ 176 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/11/2024 11:48:06am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: e64bafe

Started: 01/11/2024 11:38:10am UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1 • Initial Attempt
0% (0) 0 / 85 runs
failed over last 7 days
29.41% (25) 25 / 85 runs
flaked over last 7 days
📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt
5.33% (4) 4 / 75 runs
failed over last 7 days
52% (39) 39 / 75 runs
flaked over last 7 days
📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1 • Initial Attempt
0% (0) 0 / 67 runs
failed over last 7 days
26.87% (18) 18 / 67 runs
flaked over last 7 days

View Detailed Build Results

@scottbell scottbell modified the milestone: Target:3.3.0 Jan 9, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 9, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 9, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (450cab4) 55.96% compared to head (4e8ac13) 56.02%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7362      +/-   ##
==========================================
+ Coverage   55.96%   56.02%   +0.05%     
==========================================
  Files         660      662       +2     
  Lines       26282    26301      +19     
  Branches     2550     2551       +1     
==========================================
+ Hits        14708    14734      +26     
+ Misses      10863    10856       -7     
  Partials      711      711
Flag Coverage Δ
e2e-full 41.97% <ø> (ø)
e2e-stable 59.87% <100.00%> (+<0.01%) ⬆️
unit 48.95% <66.66%> (+0.04%) ⬆️
Files Coverage Δ
src/MCT.js 97.00% <100.00%> (+0.03%) ⬆️
src/plugins/plugins.js 100.00% <100.00%> (ø)
src/plugins/reloadAction/ReloadAction.js 100.00% <100.00%> (ø)
src/plugins/reloadAction/plugin.js 100.00% <100.00%> (ø)
...ugins/telemetryTable/components/TableComponent.vue 41.96% <100.00%> (ø)
...rc/plugins/telemetryTable/components/TableCell.vue 10.00% <0.00%> (ø)
src/ui/components/ObjectView.vue 48.13% <0.00%> (-0.43%) ⬇️

... and 10 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 450cab4...4e8ac13. Read the comment docs.

@unlikelyzero unlikelyzero added type:feature Feature. Required intentional design and removed type:enhancement labels Jan 9, 2024
@unlikelyzero unlikelyzero self-requested a review January 9, 2024 17:47
unlikelyzero
unlikelyzero requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test in openmct-yamcs which inspects the network

@scottbell
Copy link
Contributor Author

scottbell commented Jan 9, 2024 •
edited
Loading

Let's add a test in openmct-yamcs which inspects the network

@unlikelyzero Can you please make a ticket for that? We'll need to wait for this to merge before a test over there would work.

@scottbell scottbell added this to the Target:3.3.0 milestone Jan 10, 2024
ozyx
ozyx reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good overall. I found an issue where styled components would lose their styles on reload, though. We probably would want to take care of that in this PR?

Screen.Recording.2024-01-10.at.10.40.02.AM.mov
Screen.Recording.2024-01-10.at.10.40.14.AM.mov

@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 11, 2024
@scottbell
Copy link
Contributor Author

scottbell commented Jan 11, 2024 •
edited
Loading

Let's add a test in openmct-yamcs which inspects the network

@unlikelyzero Can you please make a ticket for that? We'll need to wait for this to merge before a test over there would work.

@unlikelyzero Note you currently can't create two branches of the same name for two repositories and have them link to the same ticket in Github Issues. Or at least it doesn't appear to work for me:

Screen.Recording.2024-01-11.at.1.01.13.PM.mov

I've filed two issues to further pursue this:
akhenry/openmct-yamcs#407
akhenry/openmct-yamcs#408

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 16, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 16, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 16, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 16, 2024
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Jan 17, 2024
ozyx
ozyx approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

src/ui/components/ObjectView.vue
this.updateView(true);
this.initObjectStyles();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 18, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 18, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 22, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 22, 2024
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 23, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 23, 2024
@scottbell scottbell enabled auto-merge (squash) January 23, 2024 18:41
@unlikelyzero unlikelyzero added pr:e2e:couchdb npm run test:e2e:couchdb pr:e2e:perf Trigger perf tests labels Jan 25, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jan 25, 2024
@scottbell scottbell merged commit 2b2c74d into master Jan 25, 2024
27 checks passed
@scottbell scottbell deleted the 7343-new-action-to-reload-an-individual-view-and-all-of-its-children branch January 25, 2024 05:36
@github-actions github-actions bot removed the pr:e2e:perf Trigger perf tests label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlikelyzero unlikelyzero unlikelyzero approved these changes

@ozyx ozyx ozyx approved these changes

@jvigliotta jvigliotta Awaiting requested review from jvigliotta

Assignees
No one assigned
Labels
type:feature Feature. Required intentional design
Projects
None yet
Milestone
Target:4.0.0
Development

Successfully merging this pull request may close these issues.

New action to reload an individual view and all of its children
3 participants
@scottbell @ozyx @unlikelyzero